This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project. See the GDB home page for more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Two patches for the readline lib


> In that case, would it be appropriate to use a single macro
> (eg. if defined (__DJGPP__)) to control these changes?  The old
> readline was a hodge-podge of different ifdefs of this sort.
> It'd be nice to keep it under control this time.

At first: I did the patches this way, since there was already
one or two #ifdef __MSDOS__, so I thought this is the way
like it should be. But in general I agree with you, that this is
not the best way. I would do it better if I know where to start.

>From other packages I know a way, where you can specify
in a host/target specifc file some conditionals which are then
either included in the source files or including them in the
Makefile so the flags will passed on commandline when compiling.

I would for instance introduce a define like

#define USE_STDIO_IO

to indicate that stdio functions should be used instead of
terminal functions. But I don't know where to specify this
host depended (in my case for DJGPP).

If you can give me some guidelines I will be glad.

Robert

******************************************************
* email:   Robert Hoehne <robert.hoehne@gmx.net>     *
* Post:    Am Berg 3, D-09573 Dittmannsdorf, Germany *
* WWW:     http://www.tu-chemnitz.de/~sho/rho        *
******************************************************