This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] handle_general_set: Remove useless xstrdup
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 3 Mar 2018 04:28:55 -0000
- Subject: [binutils-gdb] handle_general_set: Remove useless xstrdup
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b9671caf8fe1abd737846edf7dcd627870f986cc
commit b9671caf8fe1abd737846edf7dcd627870f986cc
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date: Fri Mar 2 23:27:46 2018 -0500
handle_general_set: Remove useless xstrdup
Unless I'm missing something very obvious, this xstrdup seems
unnecessary to me. We can pass "mode" directly to sprintf.
gdb/gdbserver/ChangeLog:
* server.c (handle_general_set): Remove unnecessary xstrdup.
Diff:
---
gdb/gdbserver/ChangeLog | 4 ++++
gdb/gdbserver/server.c | 5 +----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 70a9387..f7de928 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,9 @@
2018-03-02 Simon Marchi <simon.marchi@polymtl.ca>
+ * server.c (handle_general_set): Remove unnecessary xstrdup.
+
+2018-03-02 Simon Marchi <simon.marchi@polymtl.ca>
+
* server.c (parse_debug_format_options): Adjust to
delim_string_to_char_ptr_vec changes.
* thread-db.c (thread_db_load_search): Adjust to
diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index afdd504..64c72bd 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -847,12 +847,9 @@ handle_general_set (char *own_buf)
req = TRIBOOL_TRUE;
else
{
- char *mode_copy = xstrdup (mode);
-
/* We don't know what this mode is, so complain to GDB. */
sprintf (own_buf, "E.Unknown thread-events mode requested: %s\n",
- mode_copy);
- xfree (mode_copy);
+ mode);
return;
}