This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Add virtual destructor to selftest


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=30970df7d56bd65657c97296f31fe9862bf27e1d

commit 30970df7d56bd65657c97296f31fe9862bf27e1d
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Thu Dec 7 11:48:21 2017 -0500

    Add virtual destructor to selftest
    
    Clang 6 shows this warning
    
      In file included from /home/emaisin/src/binutils-gdb/gdb/common/selftest.c:19:
      In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:92:
      In file included from /home/emaisin/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:23:
      In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:81:
      /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on 'selftests::selftest' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
              delete __ptr;
              ^
      /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<selftests::selftest>::operator()' requested here
                get_deleter()(__ptr);
                ^
      /home/emaisin/src/binutils-gdb/gdb/common/selftest.c:57:17: note: in instantiation of member function 'std::unique_ptr<selftests::selftest, std::default_delete<selftests::selftest> >::~unique_ptr' requested here
        tests[name] = std::unique_ptr<selftest> (test);
                      ^
    
    The error is legitimate, we (the unique_ptr) are deleting selftest
    objects through the base pointer, so technically the destructor should
    be virtual, so that the destructor of the subclass is invoked.
    
    gdb/ChangeLog:
    
    	* common/selftest.h (struct selftest): Add virtual destructor.

Diff:
---
 gdb/ChangeLog         | 4 ++++
 gdb/common/selftest.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9ba0254..54aec7f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-12-07  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* common/selftest.h (struct selftest): Add virtual destructor.
+
 2017-12-07  Phil Muldoon  <pmuldoon@redhat.com>
 
 	* python/py-breakpoint.c (bppy_init): Use string_to_event_location
diff --git a/gdb/common/selftest.h b/gdb/common/selftest.h
index 35a344f..7e91bd4 100644
--- a/gdb/common/selftest.h
+++ b/gdb/common/selftest.h
@@ -31,6 +31,7 @@ namespace selftests
 
 struct selftest
 {
+  virtual ~selftest () = default;
   virtual void operator() () const = 0;
 };


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]