This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Skip gdb.threads/thread_events.exp on RSP targets properly
- From: Pedro Alves <palves at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 13 Oct 2017 11:26:08 -0000
- Subject: [binutils-gdb] Skip gdb.threads/thread_events.exp on RSP targets properly
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d7bcd5b8e55c54543389196fd18453db6961e314
commit d7bcd5b8e55c54543389196fd18453db6961e314
Author: Pedro Alves <palves@redhat.com>
Date: Fri Oct 13 12:18:50 2017 +0100
Skip gdb.threads/thread_events.exp on RSP targets properly
Fixes, with --target_board=native-extended-gdbserver:
Running ..../src/gdb/testsuite/gdb.threads/thread_events.exp ...
FAIL: gdb.threads/thread_events.exp: continue to after_join_func with messages enabled (saw 0, expected 1)
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.threads/thread_events.exp: Check gdb_protocol instead of
is_remote.
Diff:
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.threads/thread_events.exp | 7 ++++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3532ed3..6296e10 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2017-10-13 Pedro Alves <palves@redhat.com>
+ * gdb.threads/thread_events.exp: Check gdb_protocol instead of
+ is_remote.
+
+2017-10-13 Pedro Alves <palves@redhat.com>
+
* gdb.base/corefile.exp (corefile_test_run): Skip if gdb_protocol
is set.
(corefile_test_attach): Likewise. Check can_spawn_for_attach
diff --git a/gdb/testsuite/gdb.threads/thread_events.exp b/gdb/testsuite/gdb.threads/thread_events.exp
index d8d19c8..7ccef55 100644
--- a/gdb/testsuite/gdb.threads/thread_events.exp
+++ b/gdb/testsuite/gdb.threads/thread_events.exp
@@ -27,9 +27,10 @@ if ![istarget *-*-linux*] then {
return
}
-# When using gdbserver, even on Linux, we don't get notifications
-# about new threads. This is expected, so don't test for that.
-if [is_remote target] then {
+# When using the RSP, we don't get notifications about new threads.
+# This is expected, so don't test for that.
+if {[target_info gdb_protocol] == "remote"
+ || [target_info gdb_protocol] == "extended-remote"} {
return
}