This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] get_integer_valueof: Don't output value in test name
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 10 Oct 2017 19:11:03 -0000
- Subject: [binutils-gdb] get_integer_valueof: Don't output value in test name
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2f20e312aad64c0f5257b9725fa5ffa3e8a93ca2
commit 2f20e312aad64c0f5257b9725fa5ffa3e8a93ca2
Author: Simon Marchi <simon.marchi@ericsson.com>
Date: Tue Oct 10 15:10:25 2017 -0400
get_integer_valueof: Don't output value in test name
The get_integer_valueof outputs the value it has read as part of the
test name. This causes test names to vary from run to run, and adds
some noise when diffing test results. e.g.:
-PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (28770)
+PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (32238)
This patch removes that, since it's probably not very useful.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (get_integer_valueof): Don't output read value in test name.
Diff:
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/lib/gdb.exp | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 4ad0c02..dd0645c 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2017-10-10 Simon Marchi <simon.marchi@ericsson.com>
+
+ * lib/gdb.exp (get_integer_valueof): Don't output read value in test name.
+
2017-10-10 Pedro Alves <palves@redhat.com>
* gdb.mi/mi-pthreads.exp (check_mi_thread_command_set): Don't
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 48fec2f..9d8296a 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5634,7 +5634,7 @@ proc get_integer_valueof { exp default {test ""} } {
gdb_test_multiple "print /d ${exp}" "$test" {
-re "\\$\[0-9\]* = (\[-\]*\[0-9\]*).*$gdb_prompt $" {
set val $expect_out(1,string)
- pass "$test ($val)"
+ pass "$test"
}
timeout {
fail "$test (timeout)"