This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb/origin/users/qiyao/target-desc-4] Return X86_XSTATE_SSE_MASK instead of 0 in i386fbsd_core_read_xcr0


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c67782524530b3d146d0e9ac51d3338b5ddb3f95

commit c67782524530b3d146d0e9ac51d3338b5ddb3f95
Author: Yao Qi <yao.qi@linaro.org>
Date:   Mon Aug 21 10:30:48 2017 +0100

    Return X86_XSTATE_SSE_MASK instead of 0 in i386fbsd_core_read_xcr0
    
    i386fbsd_core_read_xcr0 reads the value of xcr0 from the corefile.  If
    it fails, returns 0.  This makes its caller {i386,amd64}_target_description
    has to handle this special value.  IMO, i386fbsd_core_read_xcr0 should
    return the default xcr0 in case of error.
    
    gdb:
    
    2017-08-21  Yao Qi  <yao.qi@linaro.org>
    
    	* i386-fbsd-tdep.c (i386fbsd_core_read_xcr0): Return
    	X86_XSTATE_SSE_MASK instead of 0.

Diff:
---
 gdb/i386-fbsd-tdep.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/i386-fbsd-tdep.c b/gdb/i386-fbsd-tdep.c
index 594b8f6..baca978 100644
--- a/gdb/i386-fbsd-tdep.c
+++ b/gdb/i386-fbsd-tdep.c
@@ -248,14 +248,14 @@ i386fbsd_core_read_xcr0 (bfd *abfd)
 	    {
 	      warning (_("Couldn't read `xcr0' bytes from "
 			 "`.reg-xstate' section in core file."));
-	      return 0;
+	      return X86_XSTATE_SSE_MASK;
 	    }
 
 	  xcr0 = bfd_get_64 (abfd, contents);
 	}
     }
   else
-    xcr0 = 0;
+    xcr0 = X86_XSTATE_SSE_MASK;
 
   return xcr0;
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]