This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix Fission (broken by my previous patch)
- From: Pedro Alves <palves at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 18 Jul 2017 15:14:10 -0000
- Subject: [binutils-gdb] Fix Fission (broken by my previous patch)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c5ed057625f886b14d9def3fa7488fd8bbbf7dd3
commit c5ed057625f886b14d9def3fa7488fd8bbbf7dd3
Author: David Blaikie <dblaikie@gmail.com>
Date: Tue Jul 18 16:06:17 2017 +0100
Fix Fission (broken by my previous patch)
Turns out somewhere along the refactoring of the multiple-CU support
for Fission I broke the patch before submitting it (& seems to have
broken Fission support generally).
Syncing back to the point at which the patch was committed, the
previous test results on my machine are:
expected passes: 36137
unexpected failures: 416
with the previous (broken) patch committed:
expected passes: 36131
unexpected failures: 429
With this one line patch applied on top of the broken commit:
expected passes: 36144
unexpected failures: 416
(& all other result counts remained the same in all 3 cases)
gdb/ChangeLog:
2017-07-18 David Blaikie <dblaikie@gmail.com>
* dwarf2read.c (create_cus_hash_table): Re-add lost initialization
of dwo_cu's dwo_file.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/dwarf2read.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index dfadee8..bc6e55b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-07-18 David Blaikie <dblaikie@gmail.com>
+
+ * dwarf2read.c (create_cus_hash_table): Re-add lost initialization
+ of dwo_cu's dwo_file.
+
2017-07-18 Yao Qi <yao.qi@linaro.org>
* remote.c (store_registers_using_G): Remove one line comment.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index bb69f44..079ec2d 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -9808,6 +9808,7 @@ create_cus_hash_table (struct dwo_file &dwo_file, dwarf2_section_info §ion,
per_cu.is_debug_types = 0;
per_cu.sect_off = sect_offset (info_ptr - section.buffer);
per_cu.section = §ion;
+ create_dwo_cu_data.dwo_file = &dwo_file;
init_cutu_and_read_dies_no_follow (
&per_cu, &dwo_file, create_dwo_cu_reader, &create_dwo_cu_data);