This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] darwin: Add fork-inferior.o to NATDEPFILES


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=848d907446d738604d11ab4061f3b0a8b23d4504

commit 848d907446d738604d11ab4061f3b0a8b23d4504
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Tue Jun 13 21:14:35 2017 +0200

    darwin: Add fork-inferior.o to NATDEPFILES
    
    I happened to be build-testing on macOS and found this:
    
      Undefined symbols for architecture x86_64:
    
        "fork_inferior(char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char**, void (*)(), void (*)(int), void (*)(), char const*, void (*)(char const*, char* const*, char* const*))", referenced from:
    
            darwin_create_inferior(target_ops*, char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char**, int) in darwin-nat.o
    
        "startup_inferior(int, int, target_waitstatus*, ptid_t*)", referenced from:
    
            gdb_startup_inferior(int, int) in fork-child.o
    
        "trace_start_error(char const*, ...)", referenced from:
    
            darwin_ptrace_me() in darwin-nat.o
    
        "trace_start_error_with_name(char const*)", referenced from:
    
            darwin_ptrace_me() in darwin-nat.o
    
      ld: symbol(s) not found for architecture x86_64
    
      clang: error: linker command failed with exit code 1 (use -v to see invocation)
    
    Adding fork-inferior.o fixes it.  I factored out the Darwin bits that
    are no architecture-specific in the section meant for that at the top.
    
    I only built-tested this using Travis-CI, since I don't have access to
    this platform.
    
    gdb/ChangeLog:
    
    	* configure.nat: Factor out Darwin bits that are not
    	architecture-specific.  Add fork-inferior.o.

Diff:
---
 gdb/ChangeLog     | 5 +++++
 gdb/configure.nat | 9 ++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ce3feaf..a8219dd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2017-06-13  Simon Marchi  <simon.marchi@ericsson.com>
 
+	* configure.nat: Factor out Darwin bits that are not
+	architecture-specific.  Add fork-inferior.o.
+
+2017-06-13  Simon Marchi  <simon.marchi@ericsson.com>
+
 	* configure.nat: Factor out AIX bits that are not
 	architecture-specific.  Add fork-inferior.o.
 
diff --git a/gdb/configure.nat b/gdb/configure.nat
index b9b9a40..2026ee7 100644
--- a/gdb/configure.nat
+++ b/gdb/configure.nat
@@ -81,6 +81,10 @@ case ${gdb_host} in
     aix)
 	NATDEPFILES='fork-inferior.o fork-child.o inf-ptrace.o'
 	;;
+    darwin)
+	NATDEPFILES='fork-child.o fork-inferior.o darwin-nat.o \
+	    darwin-nat-info.o'
+        ;;
 esac
 
 # This is where we actually filter by host and host CPU.
@@ -133,9 +137,8 @@ case ${gdb_host} in
 	case ${gdb_host_cpu} in
 	    i386)
 		# Host: IA86 running Darwin
-		NATDEPFILES='fork-child.o darwin-nat.o \
-		i386-darwin-nat.o x86-nat.o x86-dregs.o amd64-nat.o \
-		darwin-nat-info.o'
+		NATDEPFILES="${NATDEPFILES} i386-darwin-nat.o x86-nat.o \
+		    x86-dregs.o amd64-nat.o"
 		;;
 	esac
 	;;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]