This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix detach.exp remote check
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 2 May 2016 17:10:52 -0000
- Subject: [binutils-gdb] Fix detach.exp remote check
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=444e826c911693e6dad1cf907d81eb9dc1bef7d2
commit 444e826c911693e6dad1cf907d81eb9dc1bef7d2
Author: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon May 2 13:10:33 2016 -0400
Fix detach.exp remote check
This test seems to work with both native-gdbserver and
native-extended-gdbserver, so I removed the remote check.
When running with native-gdbserver (a stub-like target), detach makes
gdbserver stop and gdb disconnect. runto_main just spawns a brand new
gdbserver. So it tests the exact same thing twice. It doesn't hurt
though.
With native-extended-gdbserver, the test is probably a bit more useful
(and similar to native). It tests running/detaching twice using the
same gdb/gdbserver instances, since with extended-remote, you can
detach/attach/run all you want, unlike with remote.
gdb/testsuite/ChangeLog:
* gdb.base/detach.exp: Remove is_remote check.
Diff:
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.base/detach.exp | 5 -----
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index fb6538c..6d34da6 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2016-05-02 Simon Marchi <simon.marchi@ericsson.com>
+ * gdb.base/detach.exp: Remove is_remote check.
+
+2016-05-02 Simon Marchi <simon.marchi@ericsson.com>
+
* gdb.base/annota-input-while-running.exp: Don't check for
[is_remote target]. Enable annotations after running to main.
Remove unused "set test..." line.
diff --git a/gdb/testsuite/gdb.base/detach.exp b/gdb/testsuite/gdb.base/detach.exp
index 920dac2..b9343ee 100644
--- a/gdb/testsuite/gdb.base/detach.exp
+++ b/gdb/testsuite/gdb.base/detach.exp
@@ -22,11 +22,6 @@ if { ! [istarget "*-*-linux*"] } {
return 0
}
-# Are we on a target board?
-if [is_remote target] then {
- return 0
-}
-
standard_testfile attach.c
set escapedbinfile [string_to_regexp ${binfile}]