This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Fix missing IPA lib in tspeed.exp in some configurations.


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9df22175e153e1a8784afb85fc24983adf346171

commit 9df22175e153e1a8784afb85fc24983adf346171
Author: Antoine Tremblay <antoine.tremblay@ericsson.com>
Date:   Wed Jan 20 12:30:53 2016 -0500

    Fix missing IPA lib in tspeed.exp in some configurations.
    
    On Ubuntu 14.04 the following failure would be seen when running the
    tspeed.exp test on a target that supports fast tracepoints like x86_64:
    
    Target returns error code '.In-process agent library not loaded in
    process.  Fast and static tracepoints unavailable.'.
    (gdb) FAIL: gdb.trace/tspeed.exp: start trace experiment
    
    This is because the default is to link with --as-needed and the
    gdb_compile for the test is using the libs argument instead of shlib which
    corrects this issue since 6ebea266fd0a7a56c90db3ab6237ff9f6c919747 by
    adding -Wl,--no-as-needed.
    
    This patch fixes the issue by passing the lib as the shlib argument to
    gdb_compile.
    
    Tested on Ubuntu 14.04 x86_64.
    
    gdb/testsuite/ChangeLog:
    
    	* gdb.trace/tspeed.exp:  Use shlib instead of libs in gdb_compile
    	command.

Diff:
---
 gdb/testsuite/ChangeLog            | 5 +++++
 gdb/testsuite/gdb.trace/tspeed.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index b96a4ed..e0d2a7e 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-01-20  Antoine Tremblay  <antoine.tremblay@ericsson.com>
+
+	* gdb.trace/tspeed.exp:  Use shlib instead of libs in gdb_compile
+	command.
+
 2016-01-19  Simon Marchi  <simon.marchi@ericsson.com>
 
 	* Makefile.in (DO_RUNTEST): Add --status and update usages.
diff --git a/gdb/testsuite/gdb.trace/tspeed.exp b/gdb/testsuite/gdb.trace/tspeed.exp
index 6f89a2b..e638839 100644
--- a/gdb/testsuite/gdb.trace/tspeed.exp
+++ b/gdb/testsuite/gdb.trace/tspeed.exp
@@ -21,7 +21,7 @@ set executable $testfile
 set ipalib [get_in_proc_agent]
 
 if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
-	  executable [concat {debug nowarnings c} libs=$ipalib]] != "" } {
+	  executable [concat {debug nowarnings c} shlib=$ipalib]] != "" } {
     untested tspeed.exp
     return -1
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]