This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Add a cast in jit_target_read_impl
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 29 Oct 2015 17:44:02 -0000
- Subject: [binutils-gdb] Add a cast in jit_target_read_impl
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cb0a2700865a77a111994ced22fd68815e5eed63
commit cb0a2700865a77a111994ced22fd68815e5eed63
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date: Thu Oct 29 13:41:14 2015 -0400
Add a cast in jit_target_read_impl
We could change the signature of the function. However, it would
require changing gdb_target_read in jit-reader.h, which is an exported
interface. It's probably better to just add a cast in our code than to
break other people's code.
gdb/ChangeLog:
* jit.c (jit_target_read_impl): Add cast.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/jit.c | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8b79abb..78100fa 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2015-10-29 Simon Marchi <simon.marchi@polymtl.ca>
+ * jit.c (jit_target_read_impl): Add cast.
+
+2015-10-29 Simon Marchi <simon.marchi@polymtl.ca>
+
* jit.c (jit_reader_load): Add cast.
2015-10-29 Simon Marchi <simon.marchi@polymtl.ca>
diff --git a/gdb/jit.c b/gdb/jit.c
index ddc223d..7c6aede 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -491,7 +491,8 @@ typedef CORE_ADDR jit_dbg_reader_data;
static enum gdb_status
jit_target_read_impl (GDB_CORE_ADDR target_mem, void *gdb_buf, int len)
{
- int result = target_read_memory ((CORE_ADDR) target_mem, gdb_buf, len);
+ int result = target_read_memory ((CORE_ADDR) target_mem,
+ (gdb_byte *) gdb_buf, len);
if (result == 0)
return GDB_SUCCESS;
else