This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Remove some comments in debug_reg_change_callback


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=31a43dd5e1cfb8bb387885b3f641d6d2c04ac5dd

commit 31a43dd5e1cfb8bb387885b3f641d6d2c04ac5dd
Author: Yao Qi <yao.qi@linaro.org>
Date:   Tue Aug 25 11:38:28 2015 +0100

    Remove some comments in debug_reg_change_callback
    
    gdb/gdbserver:
    
    2015-08-25  Yao Qi  <yao.qi@linaro.org>
    
    	* linux-aarch64-low.c (debug_reg_change_callback): Remove comments.

Diff:
---
 gdb/gdbserver/ChangeLog           |  4 ++++
 gdb/gdbserver/linux-aarch64-low.c | 20 --------------------
 2 files changed, 4 insertions(+), 20 deletions(-)

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index d5eb882..0b7e658 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,9 @@
 2015-08-25  Yao Qi  <yao.qi@linaro.org>
 
+	* linux-aarch64-low.c (debug_reg_change_callback): Remove comments.
+
+2015-08-25  Yao Qi  <yao.qi@linaro.org>
+
 	* linux-aarch64-low.c (debug_reg_change_callback): Re-indent
 	the code.
 
diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
index 8b59eab..a8c2a24 100644
--- a/gdb/gdbserver/linux-aarch64-low.c
+++ b/gdb/gdbserver/linux-aarch64-low.c
@@ -276,26 +276,6 @@ debug_reg_change_callback (struct lwp_info *lwp, void *ptr)
 	      && (idx <= (is_watchpoint ? aarch64_num_wp_regs
 			  : aarch64_num_bp_regs)));
 
-  /* The following assertion is not right, as there can be changes
-     that have not been made to the hardware debug registers
-     before new changes overwrite the old ones.  This can happen,
-     for instance, when the breakpoint/watchpoint hit one of the
-     threads and the user enters continue; then what happens is:
-     1) all breakpoints/watchpoints are removed for all threads;
-     2) a single step is carried out for the thread that was hit;
-     3) all of the points are inserted again for all threads;
-     4) all threads are resumed.
-     The 2nd step will only affect the one thread in which the
-     bp/wp was hit, which means only that one thread is resumed;
-     remember that the actual updating only happen in
-     aarch64_linux_prepare_to_resume, so other threads remain
-     stopped during the removal and insertion of bp/wp.  Therefore
-     for those threads, the change of insertion of the bp/wp
-     overwrites that of the earlier removals.  (The situation may
-     be different when bp/wp is steppable, or in the non-stop
-     mode.)  */
-  /* gdb_assert (DR_N_HAS_CHANGED (dr_changed, idx) == 0);  */
-
   /* The actual update is done later just before resuming the lwp,
      we just mark that one register pair needs updating.  */
   DR_MARK_N_CHANGED (dr_changed, idx);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]