This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix ax.c:gdb_eval_agent_expr
- From: Pedro Alves <palves at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 21 Aug 2015 23:00:33 -0000
- Subject: [binutils-gdb] Fix ax.c:gdb_eval_agent_expr
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=99b0bb12cdb22489b403df6afe992b81bebbd9ec
commit 99b0bb12cdb22489b403df6afe992b81bebbd9ec
Author: Pedro Alves <palves@redhat.com>
Date: Fri Aug 21 23:59:33 2015 +0100
Fix ax.c:gdb_eval_agent_expr
In C++ mode:
src/gdb/gdbserver/ax.c: In function â??eval_result_type gdb_eval_agent_expr(eval_agent_expr_context*, agent_expr*, ULONGEST*)â??:
src/gdb/gdbserver/ax.c:1335:11: error: invalid conversion from â??intâ?? to â??eval_result_typeâ?? [-fpermissive]
return 1;
^
"1" as an enum eval_result_type is expr_eval_empty_expression, but
clearly this wants to return expr_eval_unhandled_opcode.
gdb/gdbserver/ChangeLog:
2015-08-21 Pedro Alves <palves@redhat.com>
* ax.c (gdb_eval_agent_expr): Return expr_eval_unhandled_opcode
instead of literal 1.
Diff:
---
gdb/gdbserver/ChangeLog | 5 +++++
gdb/gdbserver/ax.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 6103287..cd5e046 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,10 @@
2015-08-21 Pedro Alves <palves@redhat.com>
+ * ax.c (gdb_eval_agent_expr): Return expr_eval_unhandled_opcode
+ instead of literal 1.
+
+2015-08-21 Pedro Alves <palves@redhat.com>
+
* tdesc.c (default_description): Explicitly zero-initialize.
2015-08-21 Pedro Alves <palves@redhat.com>
diff --git a/gdb/gdbserver/ax.c b/gdb/gdbserver/ax.c
index c5b65fa..f94a27d 100644
--- a/gdb/gdbserver/ax.c
+++ b/gdb/gdbserver/ax.c
@@ -1332,7 +1332,7 @@ gdb_eval_agent_expr (struct eval_agent_expr_context *ctx,
op);
/* If ever GDB generates any of these, we don't have the
option of ignoring. */
- return 1;
+ return expr_eval_unhandled_opcode;
default:
ax_debug ("Agent expression op 0x%x not recognized", op);