This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] gdb.base/dso2dso.exp: Improve testcase documentation.


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=52bbc560524ec3691203eccd05207d13913a1e35

commit 52bbc560524ec3691203eccd05207d13913a1e35
Author: Joel Brobecker <brobecker@adacore.com>
Date:   Wed Aug 12 13:40:54 2015 -0700

    gdb.base/dso2dso.exp: Improve testcase documentation.
    
    gdb/testsuite/ChangeLog:
    
            * gdb.base/dso2dso.exp: Improve the testcase's documentation.

Diff:
---
 gdb/testsuite/ChangeLog            |  4 ++++
 gdb/testsuite/gdb.base/dso2dso.exp | 14 ++++++++++----
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index e4cf56c..9a46b61 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-08-13  Joel Brobecker  <brobecker@adacore.com>
+
+	* gdb.base/dso2dso.exp: Improve the testcase's documentation.
+
 2015-08-13  Pierre-Marie de Rodat  <derodat@adacore.com>
 
 	* gdb.ada/fun_renaming.exp: New testcase.
diff --git a/gdb/testsuite/gdb.base/dso2dso.exp b/gdb/testsuite/gdb.base/dso2dso.exp
index e11606c..9dc92d2 100644
--- a/gdb/testsuite/gdb.base/dso2dso.exp
+++ b/gdb/testsuite/gdb.base/dso2dso.exp
@@ -13,6 +13,16 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+# The purpose of this testcase is to verify that we can "next" over
+# a call to a function provided by one shared library made from another
+# shared library, and that GDB stops at the expected location. In this
+# case, the call is made from sub1 (provided by libdso1) and we are
+# calling sub2 (provided by libdso2).
+#
+# Note that, while this is not the main purpose of this testcase, it
+# also happens to exercise an issue with displaced stepping on amd64
+# when libdso1 is mapped at an address greater than 0xffffffff.
+
 if { [skip_shlib_tests] } {
     return 0
 }
@@ -53,10 +63,6 @@ if { ![runto_main] } {
   return -1
 }
 
-# Verify that we can "next" over the call to sub2 (provided by
-# libdso2) make from sub1 (provided by libdso1), and land at
-# the expected location.
-
 set bp_location [gdb_get_line_number "STOP HERE" [file tail $srcfile_libdso1]]
 gdb_breakpoint ${srcfile_libdso1}:${bp_location}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]