This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Don't rely on inferior I/O in gdb.base/restore.exp


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=12264a451d993a0a8635be82bed15618e0f4645f

commit 12264a451d993a0a8635be82bed15618e0f4645f
Author: Pedro Alves <palves@redhat.com>
Date:   Wed Jul 29 11:09:37 2015 +0100

    Don't rely on inferior I/O in gdb.base/restore.exp
    
    There seems to be no point in relying on stdio here.  Simply use
    gdb_continue_to_end instead.
    
    (not removing the printf calls, as the .c file is half generated.)
    
    gdb/testsuite/ChangeLog:
    2015-07-29  Pedro Alves  <palves@redhat.com>
    
    	* gdb.base/restore.exp (restore_tests): Use gdb_continue_to_end.

Diff:
---
 gdb/testsuite/ChangeLog            |  4 ++++
 gdb/testsuite/gdb.base/restore.exp | 15 +--------------
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8866884..1820b27 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
 2015-07-29  Pedro Alves  <palves@redhat.com>
 
+	* gdb.base/restore.exp (restore_tests): Use gdb_continue_to_end.
+
+2015-07-29  Pedro Alves  <palves@redhat.com>
+
 	* gdb.base/call-signal-resume.exp: Remove check for
 	gdb,noinferiorio.  Don't expect "no signal".  Use gdb_test.
 	* gdb.base/unwindonsignal.exp: Likewise.
diff --git a/gdb/testsuite/gdb.base/restore.exp b/gdb/testsuite/gdb.base/restore.exp
index a02ba4f..bd9dfbf 100644
--- a/gdb/testsuite/gdb.base/restore.exp
+++ b/gdb/testsuite/gdb.base/restore.exp
@@ -79,20 +79,7 @@ proc restore_tests { } {
         }
     }
 
-    if ![gdb_skip_stdio_test "run to completion"] {
-	send_gdb "continue\n"
-
-	gdb_expect {
-	    -re "exiting" {
-		pass "run to completion"
-	    }
-	    timeout { 
-		fail "(timeout) run to completion"
-	    }
-	}
-    } else {
-	gdb_test "continue" ".*" ""
-    }
+    gdb_continue_to_end "" continue 1
 }
 
 set prev_timeout $timeout


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]