This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Cleanup write_memory doc
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 15 Jun 2015 17:35:06 -0000
- Subject: [binutils-gdb] Cleanup write_memory doc
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cb6f16cf4f7a12f9aadddc0451d47f0511729c8d
commit cb6f16cf4f7a12f9aadddc0451d47f0511729c8d
Author: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon Jun 15 13:34:47 2015 -0400
Cleanup write_memory doc
This doc about write_memory seems outdated.
gdb/ChangeLog:
* corefile.c (write_memory): Update doc.
* gdbcore.h (write_memory): Same.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/corefile.c | 4 ++--
gdb/gdbcore.h | 6 ++----
3 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index db7fb63..a63d894 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-06-15 Simon Marchi <simon.marchi@ericsson.com>
+
+ * corefile.c (write_memory): Update doc.
+ * gdbcore.h (write_memory): Same.
+
2015-06-15 Jan Kratochvil <jan.kratochvil@redhat.com>
* linux-tdep.c (enum filterflags): Make it from anonymous enum.
diff --git a/gdb/corefile.c b/gdb/corefile.c
index a042e6d..5246f71 100644
--- a/gdb/corefile.c
+++ b/gdb/corefile.c
@@ -383,8 +383,8 @@ read_memory_typed_address (CORE_ADDR addr, struct type *type)
return extract_typed_address (buf, type);
}
-/* Same as target_write_memory, but report an error if can't
- write. */
+/* See gdbcore.h. */
+
void
write_memory (CORE_ADDR memaddr,
const bfd_byte *myaddr, ssize_t len)
diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h
index a437c8a..0c08b37 100644
--- a/gdb/gdbcore.h
+++ b/gdb/gdbcore.h
@@ -101,10 +101,8 @@ extern void read_memory_string (CORE_ADDR, char *, int);
CORE_ADDR read_memory_typed_address (CORE_ADDR addr, struct type *type);
-/* This takes a char *, not void *. This is probably right, because
- passing in an int * or whatever is wrong with respect to
- byteswapping, alignment, different sizes for host vs. target types,
- etc. */
+/* Same as target_write_memory, but report an error if can't
+ write. */
extern void write_memory (CORE_ADDR memaddr, const gdb_byte *myaddr,
ssize_t len);