This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Code cleanup: Use explicit NULL comparison
- From: Jan Kratochvil <jkratoch at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 10 Jun 2015 17:37:55 -0000
- Subject: [binutils-gdb] Code cleanup: Use explicit NULL comparison
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8847cac2f7ce6ff2c13fa611660c2dfc59c78272
commit 8847cac2f7ce6ff2c13fa611660c2dfc59c78272
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date: Wed Jun 10 19:37:19 2015 +0200
Code cleanup: Use explicit NULL comparison
gdb/ChangeLog
2015-06-10 Jan Kratochvil <jan.kratochvil@redhat.com>
Code cleanup.
* solib-target.c (library_list_start_list): Use explicit NULL
comparison.
Diff:
---
gdb/ChangeLog | 6 ++++++
gdb/solib-target.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 83845f4..5b19052 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2015-06-10 Jan Kratochvil <jan.kratochvil@redhat.com>
+ Code cleanup.
+ * solib-target.c (library_list_start_list): Use explicit NULL
+ comparison.
+
+2015-06-10 Jan Kratochvil <jan.kratochvil@redhat.com>
+
* solib-target.c (library_list_start_list): Do not dereference
variable version in its initialization. Make the VERSION check handle
NULL.
diff --git a/gdb/solib-target.c b/gdb/solib-target.c
index 891e572..f14363a 100644
--- a/gdb/solib-target.c
+++ b/gdb/solib-target.c
@@ -149,7 +149,7 @@ library_list_start_list (struct gdb_xml_parser *parser,
struct gdb_xml_value *version = xml_find_attribute (attributes, "version");
/* #FIXED attribute may be omitted, Expat returns NULL in such case. */
- if (version)
+ if (version != NULL)
{
const char *string = version->value;