This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] gdb.base/bp-permanent.exp: Tighten regex
- From: Pedro Alves <palves at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 5 Mar 2015 23:41:31 -0000
- Subject: [binutils-gdb] gdb.base/bp-permanent.exp: Tighten regex
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9494d2199f5ce0cf2a4cf5628f23ae91d933955d
commit 9494d2199f5ce0cf2a4cf5628f23ae91d933955d
Author: Pedro Alves <palves@redhat.com>
Date: Thu Mar 5 23:39:46 2015 +0000
gdb.base/bp-permanent.exp: Tighten regex
Trying to fix a permanent breakpoints bug, I broke "next" over a
regular breakpoint. "next" would immediately hit the breakpoint the
program was already stopped at. But, the "next over setup" test
failed to notice this and still issued a pass. That's because the
regex matches "testsuite" in:
Breakpoint 2 at 0x400687: file src/gdb/testsuite/gdb.base/bp-permanent.c, line 46.
gdb/testsuite/ChangeLog:
2015-03-05 Pedro Alves <palves@redhat.com>
* gdb.base/bp-permanent.exp: Tighten "next over setup" regex.
Diff:
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.base/bp-permanent.exp | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 1a76cc8..dd98483 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-03-05 Pedro Alves <palves@redhat.com>
+
+ * gdb.base/bp-permanent.exp: Tighten "next over setup" regex.
+
2015-03-04 Simon Marchi <simon.marchi@ericsson.com>
* lib/mi-support.exp (mi_expect_interrupt): Accept
diff --git a/gdb/testsuite/gdb.base/bp-permanent.exp b/gdb/testsuite/gdb.base/bp-permanent.exp
index d0ed991..81a5293 100644
--- a/gdb/testsuite/gdb.base/bp-permanent.exp
+++ b/gdb/testsuite/gdb.base/bp-permanent.exp
@@ -96,7 +96,7 @@ proc test {always_inserted sw_watchpoint} {
# Run the "setup" function in the inferior. This memcpy's the
# breakpoint instruction to a buffer in the inferior.
- gdb_test "next" "test.*" "next over setup"
+ gdb_test "next" "test_basics \\(\\).*" "next over setup"
delete_breakpoints