This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
gdb and binutils branch master updated. 22fd09ae995556cc1b898afe3d5901eb161d1102
- From: jkratoch at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: 21 Aug 2014 18:39:31 -0000
- Subject: gdb and binutils branch master updated. 22fd09ae995556cc1b898afe3d5901eb161d1102
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via 22fd09ae995556cc1b898afe3d5901eb161d1102 (commit)
from 656e8868f333de49bf22e10112392ca404e5eb67 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=22fd09ae995556cc1b898afe3d5901eb161d1102
commit 22fd09ae995556cc1b898afe3d5901eb161d1102
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date: Thu Aug 21 20:36:20 2014 +0200
Fix 'gcore' with exited threads
Program received signal SIGABRT, Aborted.
[...]
(gdb) gcore foobar
Couldn't get registers: No such process.
(gdb) info threads
[...]
(gdb) gcore foobar
Saved corefile foobar
(gdb)
gcore tries to access the exited thread:
[Thread 0x7ffff7fce700 (LWP 6895) exited]
ptrace(PTRACE_GETREGS, 6895, 0, 0x7fff18167dd0) = -1 ESRCH (No such process)
Without the TRY_CATCH protection testsuite FAILs for:
gcore .../gdb/testsuite/gdb.threads/gcore-thread0.test
Cannot find new threads: debugger service failed
(gdb) FAIL: gdb.threads/gcore-thread.exp: save a zeroed-threads corefile
+
core .../gdb/testsuite/gdb.threads/gcore-thread0.test
".../gdb/testsuite/gdb.threads/gcore-thread0.test" is not a core dump: File format not recognized
(gdb) FAIL: gdb.threads/gcore-thread.exp: core0file: re-load generated corefile (bad file format)
Maybe the TRY_CATCH could be more inside update_thread_list().
Similar update_thread_list() call is IMO missing in procfs_make_note_section()
but I do not have where to verify that change.
gdb/ChangeLog
2014-08-21 Jan Kratochvil <jan.kratochvil@redhat.com>
* linux-tdep.c (linux_corefile_thread_callback): Ignore THREAD_EXITED.
(linux_make_corefile_notes): call update_thread_list, protected against
exceptions.
gdb/testsuite/ChangeLog
2014-08-21 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.threads/gcore-stale-thread.c: New file.
* gdb.threads/gcore-stale-thread.exp: New file.
-----------------------------------------------------------------------
Summary of changes:
gdb/ChangeLog | 6 ++
gdb/linux-tdep.c | 12 +++++
gdb/testsuite/ChangeLog | 5 ++
gdb/testsuite/gdb.threads/gcore-stale-thread.c | 48 ++++++++++++++++++
gdb/testsuite/gdb.threads/gcore-stale-thread.exp | 57 ++++++++++++++++++++++
5 files changed, 128 insertions(+), 0 deletions(-)
create mode 100644 gdb/testsuite/gdb.threads/gcore-stale-thread.c
create mode 100644 gdb/testsuite/gdb.threads/gcore-stale-thread.exp
hooks/post-receive
--
gdb and binutils