This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
gdb and binutils branch master updated. 13b448cdf796fdc4a92e37a6bc20ce785b7c65dd
- From: qiyao at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: 19 Aug 2014 13:36:45 -0000
- Subject: gdb and binutils branch master updated. 13b448cdf796fdc4a92e37a6bc20ce785b7c65dd
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via 13b448cdf796fdc4a92e37a6bc20ce785b7c65dd (commit)
from 817e0957a556d241be6f8c5e0e649ac53b1fb020 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=13b448cdf796fdc4a92e37a6bc20ce785b7c65dd
commit 13b448cdf796fdc4a92e37a6bc20ce785b7c65dd
Author: Yao Qi <yao@codesourcery.com>
Date: Tue Aug 12 09:14:08 2014 +0800
Set breakpoint on the right line
In gdb.base/watchpoint-hw-hit-once.exp, test scans source and set
breakpoint on the line having "break-at-exit",
gdb_breakpoint [gdb_get_line_number "break-at-exit"]
However, in watchpoint-hw-hit-once.c, there are two lines having
this key word:
dummy = 1; /* Stub to catch break-at-exit after WATCHEE has been hit. */
dummy = 2; /* break-at-exit */
so the test sets breakpoint on the first one, while I think it is
expected to set breakpoint on the second one, as far as I can tell
from the comments in watchpoint-hw-hit-once.c:
/* Stub lines are present as no breakpoints/watchpoint gets hit if current PC
already stays on the line PC while entering "step"/"continue". */
This patch is to change the source matching pattern so that test
can correctly set breakpoint on the right line. This patch fixes
a fail we found on arm-none-eabi target.
(gdb) PASS: gdb.base/watchpoint-hw-hit-once.exp: continue
continue^M
Continuing.^M
^M
*** EXIT code 0^M
[Inferior 1 (Remote target) exited normally]^M
(gdb) FAIL: gdb.base/watchpoint-hw-hit-once.exp: continue to break-at-exit (the program exited)
Run it again on x86_64-linux, no result changes.
gdb/testsuite:
2014-08-19 Yao Qi <yao@codesourcery.com>
* gdb.base/watchpoint-hw-hit-once.exp: Set breakpoint on the
right line.
-----------------------------------------------------------------------
Summary of changes:
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.base/watchpoint-hw-hit-once.exp | 2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
hooks/post-receive
--
gdb and binutils