This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
gdb and binutils branch master updated. c658158d936f25dca30cc89260168a5c0be3a24c
- From: palves at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: 19 Feb 2014 19:07:52 -0000
- Subject: gdb and binutils branch master updated. c658158d936f25dca30cc89260168a5c0be3a24c
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via c658158d936f25dca30cc89260168a5c0be3a24c (commit)
via ba3481708d3f18e77ab6c000385b131c76d2733e (commit)
from ac01945bf17f3699de5493da23f14ea92549617a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c658158d936f25dca30cc89260168a5c0be3a24c
commit c658158d936f25dca30cc89260168a5c0be3a24c
Author: Pedro Alves <palves@redhat.com>
Date: Wed Feb 19 18:25:41 2014 +0000
common/ptid.h: Mention that process_stratum targets should prefer ptid.lwp.
It's best that we standardize on process_stratum targets using the
ptid.lwp field to store thread ids. The idea being leave the ptid.tid
field free for any thread_stratum target that might want to sit on
top. This patch adds a comment in that direction to struct ptid's
definition.
gdb/
2014-02-19 Pedro Alves <palves@redhat.com>
* common/ptid.h (struct ptid): Mention that process_stratum
targets should prefer ptid.lwp.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ba3481708d3f18e77ab6c000385b131c76d2733e
commit ba3481708d3f18e77ab6c000385b131c76d2733e
Author: Pedro Alves <palves@redhat.com>
Date: Wed Feb 19 18:25:40 2014 +0000
remote.c: Use the ptid.lwp field to store remote thread ids rather than ptid.tid.
From GDB's perspective, independently of how the target really
implements threads, gdb/remote sees all threads as if kernel/system
threads. A rationale along theses lines led to gdbserver storing
thread ids in ptid.lwp in all ports.
Because remote.c is currently using ptid.tid, we can't make gdbserver
and gdb share bits of remote-specific code that manipulates ptids
(e.g., write_ptid/read_ptid).
This patch thus makes remote.c use ptid.lwp instead of ptid.tid.
I believe that on the GDB side too, it's best that we standardize on
process_stratum targets using the ptid.lwp field to store thread ids
anyway. The idea being leave the ptid.tid field free for any
thread_stratum target that might want to sit on top.
Tested on x86_64 Fedora 17, w/ local gdbserver.
gdb/
2014-02-19 Pedro Alves <palves@redhat.com>
* remote.c (remote_thread_alive, write_ptid, read_ptid)
(read_ptid, remote_newthread_step, remote_threads_extra_info)
(remote_get_ada_task_ptid, append_resumption, remote_stop_ns)
(threadalive_test, remote_pid_to_str): Use the ptid.lwp field to
store remote thread ids rather than ptid.tid.
(_initialize_remote): Adjust.
-----------------------------------------------------------------------
Summary of changes:
gdb/ChangeLog | 14 ++++++++++++++
gdb/common/ptid.h | 7 ++++++-
gdb/remote.c | 34 +++++++++++++++++-----------------
3 files changed, 37 insertions(+), 18 deletions(-)
hooks/post-receive
--
gdb and binutils