This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
gdb and binutils branch master updated. f23981e9917c0322223aaa8941bd1ca13d1dcc58
- From: palves at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: 12 Dec 2013 10:20:58 -0000
- Subject: gdb and binutils branch master updated. f23981e9917c0322223aaa8941bd1ca13d1dcc58
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via f23981e9917c0322223aaa8941bd1ca13d1dcc58 (commit)
from 43942612f4278418e9b6c48c86e4f02798611f74 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f23981e9917c0322223aaa8941bd1ca13d1dcc58
commit f23981e9917c0322223aaa8941bd1ca13d1dcc58
Author: Pedro Alves <palves@redhat.com>
Date: Wed Dec 11 09:49:08 2013 +0000
Eliminate UNSUPPORTED_ERROR.
I have a case that could use an exception for "unsupported feature".
I found UNSUPPORTED_ERROR, but looking deeper, I think as is, reusing
it for other things would be fragile. E.g., if the Python script
sourced by source_script_from_stream triggers any other missing
functionality that would result in UNSUPPORTED_ERROR being propagated
out to source_script_from_stream, that would confuse the error for
Python not being built into GDB.
This patch thus redoes things a little. Instead of using an exception
for the "No Python" scenario, check whether Python is configured in
before actually trying to source the file. It adds a new function
instead of using #ifdef HAVE_PYTHON directly, as that is better at
avoiding bitrot, as both Python and !Python paths are visible to the
compiler this way.
Tested on Fedora 17, with and without Python.
gdb/
2013-12-12 Pedro Alves <palves@redhat.com>
* cli/cli-cmds.c (source_script_from_stream) Use have_python
instead of catching UNSUPPORTED_ERROR.
* exceptions.h (UNSUPPORTED_ERROR): Delete.
* python/python.c (source_python_script) [!HAVE_PYTHON]: Internal
error if called.
* python/python.h (have_python): New static inline function.
-----------------------------------------------------------------------
Summary of changes:
gdb/ChangeLog | 9 +++++++++
gdb/cli/cli-cmds.c | 26 +++++++-------------------
gdb/exceptions.h | 3 ---
gdb/python/python.c | 5 +++--
gdb/python/python.h | 13 +++++++++++++
5 files changed, 32 insertions(+), 24 deletions(-)
hooks/post-receive
--
gdb and binutils