Re: [SCM] master: Set hit.count to 2 in testWatchpointActionContinue.

[Phil Muldoon <pmuldoon at redhat dot com>]

pmuldoon@sourceware.org wrote:

This is a good example of an author being snared and told off by his own 
test. When I added the read_only test, I reused the source variable as 
place to "write to" from the read_only variable "read from". However 
this makes the source watchpoint fire twice in the 
testWatchpontActionContinue test (correctly) as it adds another "source" 
variable write. When watching the variable "source" two writes means two 
watchpoint triggers; this is because this particular  always continues 
and never blocks.

Regards

Phil
> The branch, master has been updated
>        via  59acb89f662cace8e7b3cb61f86c8c93f9b8cea1 (commit)
>       from  dd89b9e98efbe563cef22c6b18b9b135523a8205 (commit)
>
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email.
>
> - Log -----------------------------------------------------------------
> commit 59acb89f662cace8e7b3cb61f86c8c93f9b8cea1
> Author: Phil Muldoon <pmuldoon@redhat.com>
> Date:   Mon Apr 14 14:20:49 2008 +0100
>
>     Set hit.count to 2 in testWatchpointActionContinue.
>     
>     2008-04-14  Phil Muldoon  <pmuldoon@redhat.com>
>     
>     	* TestTaskObserverWatchpoint.java (testRunningAndReadOnlyWatchpoint): New.
>     	(testWatchpointActionContinue): Change hit.code to 2,(test above adds another hit).
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  frysk-core/frysk/proc/ChangeLog                    |    1 +
>  .../frysk/proc/TestTaskObserverWatchpoint.java     |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
>
> First 500 lines of diff:
> diff --git a/frysk-core/frysk/proc/ChangeLog b/frysk-core/frysk/proc/ChangeLog
> index 63785a8..a671460 100644
> --- a/frysk-core/frysk/proc/ChangeLog
> +++ b/frysk-core/frysk/proc/ChangeLog
> @@ -1,6 +1,7 @@
>  2008-04-14  Phil Muldoon  <pmuldoon@redhat.com>
>  
>  	* TestTaskObserverWatchpoint.java (testRunningAndReadOnlyWatchpoint): New.
> +	(testWatchpointActionContinue): Change hit.code to 2,(test above adds another hit).
>  
>  2008-04-10  Phil Muldoon  <pmuldoon@redhat.com>
>  
> diff --git a/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java b/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java
> index 2fde8c2..6650fe3 100644
> --- a/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java
> +++ b/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java
> @@ -346,7 +346,7 @@ extends TestLib
>  
>  	// Make sure it triggered.
>  	assertTrue("added", watch.added);
> -	assertEquals("hit code", 1, watch.hit);
> +	assertEquals("hit code", 2, watch.hit);
>  	assertEquals("Task terminated", 1, to.hit);
>      }
>  
>
>
> hooks/post-receive
> --
> frysk system monitor/debugger
>