This is the mail archive of the frysk@sourceware.org mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] Make TestDebugInfoStackTrace.frameAssertions() more robust


Hi,

While working on more unwind issues I noticed that
TestDebugInfoStackTrace.frameAssertions() didn't check for the actual
kill() and syscall() functions (only the internal library names). With
my new work the actual function names show up sometimes (not committed
yet), so these also need to be matched.

frysk-core/frysk/debuginfo/ChangeLog
2008-03-19  Mark Wielaard  <mwielaard@redhat.com>

    * TestDebugInfoStackTrace (frameAssertions): Also check for function
    names starting with kill or syscall.

Committed and pushed,

Mark


index 1939bb9..e932858 100644
--- a/frysk-core/frysk/debuginfo/TestDebugInfoStackTrace.java
+++ b/frysk-core/frysk/debuginfo/TestDebugInfoStackTrace.java
@@ -407,8 +407,8 @@ public class TestDebugInfoStackTrace
        String frameName =  this.frameTracker[i][index][2];
        
        while (frameName == null
-              || frameName.indexOf("kill") > 0
-              || frameName.indexOf("syscall") > 0)
+              || frameName.indexOf("kill") >= 0
+              || frameName.indexOf("syscall") >= 0)
          {
            index++;
            frameName = this.frameTracker[i][index][2];



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]