This is the mail archive of the
frysk@sourceware.org
mailing list for the frysk project.
Re: [SCM] master: Updating register group names.
- From: Andrew Cagney <cagney at redhat dot com>
- To: Mark Wielaard <mark at klomp dot org>, Jose Flavio Aguilar Paulino <joseflavio at gmail dot com>
- Cc: frysk at sourceware dot org
- Date: Tue, 04 Dec 2007 09:57:50 -0500
- Subject: Re: [SCM] master: Updating register group names.
- References: <20071204110100.9581.qmail@sourceware.org> <1196775231.3808.2.camel@dijkstra.wildebeest.org>
Mark Wielaard wrote:
Hi Jose,
On Tue, 2007-12-04 at 11:01 +0000, jflavio@sourceware.org wrote:
Author: Jose Flavio Aguilar Paulino <joseflavio@gmail.com>
Date: Tue Dec 4 08:45:03 2007 -0200
Updating register group names.
This does break one test:
testToString(frysk.isa.TestISA)junit.framework.ComparisonFailure:
toString expected:<...> but was:<...32BE>
public static final ISA PPC32BE
- = new ISA(ByteOrder.BIG_ENDIAN, 4, "PowerPC");
+ = new ISA(ByteOrder.BIG_ENDIAN, 4, "PowerPC32BE");
public static final ISA PPC64BE
- = new ISA(ByteOrder.BIG_ENDIAN, 8, "PowerPC");
+ = new ISA(ByteOrder.BIG_ENDIAN, 8, "PowerPC64BE");
I am not sure what the right String is. But it should be similar in both
the isa and the test.
Just "PowerPC", the string specifies the the ISA family. Thing's like
"big-endian" and 64-bit are derived from the other parameters. The test
looks like this:
public void testToString() {
assertEquals("toString", "32-bit big-endian PowerPC",
ISA.PPC32BE.toString());
}
Andrew