Re: [patch] fix bug 4612

[Mark Wielaard <mark at klomp dot org>]

Hi Elena,

On Mon, 2007-07-30 at 13:26 -0400, Elena Zannoni wrote:
> To clarify:
> This patch was discussed on IRC and Mark and other folks have provided
> useful feedback and testing.  The patch had also been tested by Kris before
> being posted by Pearly. Kris has already committed Pearly's patch,
> since nobody but him and Pearly are concentrating on that part
> of GUI right now.
> 
> An ack to the mailing list could have been sent, since discussing things
> on IRC exclusively is not really optimal practice for a fully open
> source project. I'd like to take the opportunity to appeal to the
> wider group to be more consistent in doing so.

That seems like a good policy. I will also try to summarize and post
more about anything on the list that was discussed on irc to keep an
archive of stuff for people to look at. We seem pretty scattered around
according to timezones over the whole planet so there is always someone
missing out on some discussion somewhere.

> Kris committing this patch has aroused an unfortunate not so friendly
> private reaction, which I will not post here. What I'd like to bring up here
> though is about approval of patches. It is my personal belief for it to
> be good practice to not be anointed with write access just because one
> happens to be tasked to work on the project. I have asked Pearly to submit
> a few patches before applying for write access to the repository. Since
> the group has been widening, and hopefully it will widen more as
> Frysk matures nicely, there are cases in which people w/o commit rights
> will want to post patches occasionally (we have seen this already with
> Tom or others). So far people who felt comfortable taking responsibility
> for such patches have committed them. I do believe this is a good way
> to incorporate contributions from outside the committers list.

Yes, I am more than happy to take responsibility for reviewing and
committing peoples patches if they ask. In this case I thought the patch
was good but wanted to have a second opinion from Rick and Kris before
committing because they are much more familiar with gui code than me.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part