This is the mail archive of the frysk@sourceware.org mailing list for the frysk project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: frysk-core/frysk/proc Breakpoint.java ChangeLo ...

mark@sourceware.org wrote:
Modified files:
frysk/proc : Breakpoint.java ChangeLog Isa.java IsaIA32.java IsaPowerPC.java IsaX8664.java Proc.java 

Log message:
	* Proc.java (outOfLineAddresses): New private final field.
	(requestedOutOfLineAddresses): New boolean field.
	(getOutOfLineAddress): New method.
	(doneOutOfLine): Likewise.

Mark,

All this new stuff is very exciting. It is awesome to see!

A minor nitpick if you will. I've not really looked at this code in a huge amount of detail, so please excuse my nativity here, but can't this code go and live in the live/LinuxProc.java implementation instead of the abstract Proc.java? The scope rules are package-private so they are not public apis? Other than keeping Proc.java as simple as possible, I'm not hugely worried.

Regards

Phil

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]