This is the mail archive of the frysk@sourceware.org mailing list for the frysk project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: What does brokenIfUtraceXXX() test for?

From: Andrew Cagney <cagney at redhat dot com>
To: Mark Wielaard <mark at klomp dot org>
Cc: frysk at sourceware dot org
Date: Wed, 04 Jul 2007 15:19:11 -0400
Subject: Re: What does brokenIfUtraceXXX() test for?
References: <1183392408.3622.24.camel@dijkstra.wildebeest.org>

See bug 3639. Seems fixing it slipped through the cracks, I fixed/closed the bug. 3489 contains a hidden references 3639 in one of the comments; I've also made that more obvious.

As for brokenIfUtraceXXX, be careful to not read anything into it. The test has an unresolved problem, see BUG XXXXX :-)

Mark Wielaard wrote:

Hi,

I am seeing two failures on 2.6.21-1.3228.fc7 x86 SMP:

testTerminateKillKILL(frysk.proc.TestTaskTerminateObserver)junit.framework.AssertionFailedError: terminating value expected:<-9> but was:<128>
testTerminatingKillKILL(frysk.proc.TestTaskTerminateObserver)junit.framework.AssertionFailedError: terminating value expected:<-9> but was:<128>

That are guarded by brokenIfUtraceXXX() which has as explanation:

     /**
     * A method that returns true, and prints broken, when the build
     * kernel includes UTRACE.
     */

So, tests guarded by that ever never expected to succeed with utrace
enabled? Or is it more subtle than that? Both bugs referenced through
these guards (#3525 and #3489) are closed already.

Cheers,

Mark

References:
- What does brokenIfUtraceXXX() test for?
  - From: Mark Wielaard

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]