Re: frysk-common ./ChangeLog ./Makefile.rules ./fr ...

[Kris Van Hees <kris dot van dot hees at oracle dot com>]

As you are well aware, the requirement for this came from the need to be
able to run tests even in the event of warnings being triggered during
the build.  That requirement was expressed by myself on the IRC channel
yesterday, and led to a lengthy discussion about the impact of this
change, and was explained at great length.

You suggested first imeplementing this as something to control on the
make command line, and I responded quite clearly that I might implement
it as a configure option right away, especially since it was (before
your and my changes) controlled by a hardcoded AM_GCJFLAGS variable.
You pointed out that change was easy, and that you moved the wiring of
the -Werror flag to common/frysk-common.ac (from Makefile.rules).  I
requested you to let me know what that change was commited, which you
never did.

As I explained at great length yesterday on the IRC channel, controlling
this from the make command line is error prone, and is not a reasonable
solution for using this in automated builds, where dependency on the
exactness of the *FLAGS variables is a liability because changes in the
tree may require those variables to be tweaked, which is (for default
builds) handled nicely by theautoconf/automake/configure setup, but
would require manual intervention (once someone notices the problem -
which could take a while).  Allowing this to be controlled in a clean
and consistent way, maintained as part of the tree so it is known to be
consistent and correct will save quite a few headaches, and follows the
pattern set by numerous autoconf-based projects throughout the
community.  This is hardly an exception.

Again, we went over all this yesterday.  I am somewhat at a loss why
this has to get re-discussed yet again.  Surely we can use our time in a
more productive manner.

	Cheers,
	Kris

Mar 08 14:02:33 cagney  SqRoot, so can you work through the issues with
getting "make *FLAGS=" working as one would expect?  Control "-g -O -Werror"?
Hopefuly elena isn't going to spin that me asking for that is stonewalling


On Fri, Mar 09, 2007 at 10:54:51AM -0500, Andrew Cagney wrote:
> Just FYI,
> 
> The proposal was for "make CFLAGS=..." be fixed so that it could control 
> -Werror behavior at build time.  This is the important first step as it 
> gives the developer fine-grained control over the build, for instance, 
> being able to compile sinngle files without warnings vis:
>    make GCJFLAGS='-g -O' frysk/bindir/fhpd.o
> If that is working then controlling that at configure time with, say:
>    .../configure GCJFLAGS='-g -O'
> becomes possible.  Adding an option to also control this is just eye candy.
> 
> I'll commit changes to fix this.
> 
> Andrew
> 
> >http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-common/Makefile.rules.diff?cvsroot=frysk&r1=1.195&r2=1.196
> >http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-common/frysk-common.ac.diff?cvsroot=frysk&r1=1.13&r2=1.14
> >http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-common/m4/frysk_werror.m4.diff?cvsroot=frysk&r1=NONE&r2=1.1
> >
> >  
>