This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: frysk-imports/frysk/expunit ChangeLog Equals.j ...


Mark,

I don't follow these changes. If the code stripping of the matched text was removed, then TestExpect and other code would start failing - was this tested? And the grouping code is so that expect clients can access the parts that were matched, that functionality was lost?

Andrew

mark@sourceware.org wrote:
CVSROOT:	/cvs/frysk
Module name:	frysk-imports
Changes by:	mark@sourceware.org	2007-03-05 13:52:02

Modified files:
frysk/expunit : ChangeLog Equals.java Expect.java Match.java


Log message:
	* Expect.java (expectMilliseconds): Don't use unimplemented methods.
	* Match.java: Remove unimplemented group methods.
	* Equals.java: Likewise.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/ChangeLog.diff?cvsroot=frysk&r1=1.8&r2=1.9
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/Equals.java.diff?cvsroot=frysk&r1=1.1&r2=1.2
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/Expect.java.diff?cvsroot=frysk&r1=1.8&r2=1.9
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/Match.java.diff?cvsroot=frysk&r1=1.1&r2=1.2



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]