This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: frysk-core/frysk gui/srcwin/SourceWindow.java ...


Mike Cvet wrote:
On Wed, 2006-12-13 at 08:58 -0500, Andrew Cagney wrote:
Mike,

is this null stack frames, or null source and line? The source window should be able to assume that there is at least one stack frame.

Andrew


Both, actually - its possible for the call to
StackFactory.createStackFrame to break completely and leave the stack
trace null. This commit also covers the situation where the StackFrame
seems to have been initialized properly, but for some reason a function
name can't be pulled out of it. I believe both of these cases have been
witnessed when testing on johntheripper with varying amounts of
optimization and debuginfo/unwindinfo
The source window code doesn't need to handle this - instead it should rely on there being a frame.

The place to fix this is in .createStackFrame setting things up so that it always guarentees some sort of stack frame.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]