This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New funit options.


A few minor things just committed.

Andrew Cagney wrote:
> Chris these options look great,
>
> In looking over this I noticed a few small nits:
> - the code already has .testFiler, this adds a different filtering,
> can the two be merged, instead with just --filter?  Java regular
> expressions let you specify exclusions directly

This will take more time--deferred.

> - or, instead of -o (which typically is associated with output) is
> --exclude better?

Done.

> - for coding, again, please use (foo == null) and not the reverse; in
> fact for that code it is simpler/easier to just always create the
> array and then let the for() loop using .size() as the upper bound

Done.

> - was the man page updated

Done.

>
> Andrew
>
> Chris Moller wrote:
>> I've added a couple of options to funit:
>>
>>  -o, -omit <test-spec>           Specify a test to omit.  Each passed
>> option will be interpreted as the regex specification of a test to
>> omit.  This option may be used multiple times.
>>
>>   -i, -include <test-spec>        Specify a test to include, ovirriding
>> an omit specification.  Each passed option will be interpreted as the
>> regex specification of a test to include.  This option may be used
>> multiple times.
>>
>>
>> This lets you do stuff like ./funit -o ".*TestExec" to kill tests that
>> are hanging, or some such naughty behaviour.  Using the -i switch, you
>> can do stuff like ./funit -o '.*' -i ".*\.sys\..*" to first omit all
>> tests then selectively include specific ones like, in this case, all the
>> *.sys.* tests.  Multiple -i and -o switches can be specified--the
>> effects are cumulative.  Regardless of the order in which -i and -o
>> switches are specified, the result will be the same: a -i <spec> will
>> always override a matching -o <spec>
>>
>>   
>

Attachment: signature.asc
Description: OpenPGP digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]