This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...


Mark Wielaard wrote:
Hi Andrew,

On Thu, 2006-10-12 at 14:52 +0000, cagney@sourceware.org wrote:
2006-10-12 Andrew Cagney <cagney@redhat.com>

* TestBreakpoints.java (setUp): Move code creating event loop from
here ...
(testHitAndRun, testInsertRemove, testAddLots): ... to here.
(tearDown): Only shutdown the eventLoop when it is running.

This change doesn't make sense to me. setUp() and tearDown() are called before and after every test, which is why all common setup/teardown code is in those methods. Moving parts of it into the individual tests makes the code harder to maintain imho. Could you explain why you think it is necessary?

See http://sourceware.org/bugzilla/show_bug.cgi?id=3354
You're already on the CC list.
Also, could you please keep the file indentation (GNU style) please (*).
That sounds like a bug in EMACS.

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]