This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Making the run-until-ack in frysk.proc.TestLib.AckDaemon explicit


Hello,

On IRC, a number of times, its been pointed out that the AckDaemon interface isn't very explicit about how it will run the event loop (it does it for instance when telling a process to fork). To address this, I'm thinking of changing the interface to:

@@ -139,10 +139,10 @@ public class StressAttachDetachSignaledT
           {
               switch (iteration % 2) {
               case 0:
-                   child.addClone ();
+                   child.sendAddClone ().assertRunUntilAcks ();
                   break;
               case 1:
-                   child.delClone ();
+                   child.sendDelClone ().assertRunUntilAcks ();
                   break;
               }
           }

I.e., both the "send" and need to run the event loop are very explicit. Yes, the down side is that it is more verbose, I think clarity trumps verbosity :-)

thoughts?
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]