This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: First commit


Mark Wielaard wrote:
Hi,

The build was broken by a small typo in SourceWindowFactory.java. Since
Cagney granted me commit access to CVS I thought this was a nice
oppertunity to test out my new powers. I commited the following fixlet
which lets me compile everything again:

2006-06-20 Mark Wielaard <mark@klomp.org>

* SourceWindowFactory.java (finishSourceWin): Fix if block.

To which list are patches normally send and discussed? I could only find
frysk-cvs. And what coding style is used? Is there a description (and
more importantly an emacs mode) of it?

Cheers,

Mark

P.S. I am seeing the following after every cvs command that uses the
server:
Write failed flushing stdout buffer.
write stdout: Broken pipe
But everything seems to work fine. Anyone else seeing this?
------------------------------------------------------------------------


Index: frysk-gui/frysk/gui/srcwin/SourceWindowFactory.java
===================================================================
RCS file: /cvs/frysk/frysk-gui/frysk/gui/srcwin/SourceWindowFactory.java,v
retrieving revision 1.47
diff -u -r1.47 SourceWindowFactory.java
--- frysk-gui/frysk/gui/srcwin/SourceWindowFactory.java 20 Jun 2006 20:59:15 -0000 1.47
+++ frysk-gui/frysk/gui/srcwin/SourceWindowFactory.java 21 Jun 2006 09:01:16 -0000
@@ -174,7 +174,7 @@

// If we don't have a dom, tell the task to continue
catch (NoDebugInfoException e){
- if(blockerMap.containsKey(task))
+ if(blockerMap.containsKey(task)){
TaskObserver.Attached o = (TaskObserver.Attached) blockerMap.get(task);
task.requestDeleteAttachedObserver(o);
}
Thanks for catching this Mark, I'll commit it right now


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]