This is the mail archive of the
frysk-cvs@sources.redhat.com
mailing list for the frysk project.
[SCM] master: Delete unused Proc.requestRefresh().
- From: cagney at sourceware dot org
- To: frysk-cvs at sourceware dot org
- Date: 17 Mar 2008 20:35:36 -0000
- Subject: [SCM] master: Delete unused Proc.requestRefresh().
- Reply-to: frysk at sourceware dot org
The branch, master has been updated
via 5f46b1275db9112a0816092ca96a4e9816405e21 (commit)
from 986b1328a40fd806e01e5f2aee29ee3a4fe0f0a9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email.
- Log -----------------------------------------------------------------
commit 5f46b1275db9112a0816092ca96a4e9816405e21
Author: Andrew Cagney <cagney@redhat.com>
Date: Mon Mar 17 16:33:50 2008 -0400
Delete unused Proc.requestRefresh().
frysk-core/frysk/proc/ChangeLog
2008-03-17 Andrew Cagney <cagney@redhat.com>
* Proc.java (requestRefresh()): Delete.
(sendRefresh()): Make concrete.
frysk-core/frysk/proc/dead/ChangeLog
2008-03-17 Andrew Cagney <cagney@redhat.com>
* DeadProc.java (requestRefresh()): Delete.
(sendRefresh()): Delete.
frysk-core/frysk/proc/dummy/ChangeLog
2008-03-17 Andrew Cagney <cagney@redhat.com>
* DummyProc.java (requestRefresh()): Delete.
(sendRefresh()): Delete.
frysk-core/frysk/proc/live/ChangeLog
2008-03-17 Andrew Cagney <cagney@redhat.com>
* LinuxPtraceProcState.java (handleRefresh(LinuxPtraceProc)): Delete.
* LinuxPtraceProc.java (requestRefresh()): Delete.
-----------------------------------------------------------------------
Summary of changes:
frysk-core/frysk/proc/ChangeLog | 3 +++
frysk-core/frysk/proc/Proc.java | 13 +++++--------
frysk-core/frysk/proc/dead/ChangeLog | 3 +++
frysk-core/frysk/proc/dead/DeadProc.java | 11 -----------
frysk-core/frysk/proc/dummy/ChangeLog | 3 +++
frysk-core/frysk/proc/dummy/DummyProc.java | 5 -----
frysk-core/frysk/proc/live/ChangeLog | 3 +++
frysk-core/frysk/proc/live/LinuxPtraceProc.java | 13 -------------
.../frysk/proc/live/LinuxPtraceProcState.java | 8 --------
9 files changed, 17 insertions(+), 45 deletions(-)
First 500 lines of diff:
diff --git a/frysk-core/frysk/proc/ChangeLog b/frysk-core/frysk/proc/ChangeLog
index 64a9d1d..4255d71 100644
--- a/frysk-core/frysk/proc/ChangeLog
+++ b/frysk-core/frysk/proc/ChangeLog
@@ -1,5 +1,8 @@
2008-03-17 Andrew Cagney <cagney@redhat.com>
+ * Proc.java (requestRefresh()): Delete.
+ (sendRefresh()): Make concrete.
+
* ProcObserver.java (ProcAction): Move to ...
* ProcBlockObserver.java: ... here; new interface.
* StressTestAbandon.java: Update.
diff --git a/frysk-core/frysk/proc/Proc.java b/frysk-core/frysk/proc/Proc.java
index 5cd5455..4e66cb9 100644
--- a/frysk-core/frysk/proc/Proc.java
+++ b/frysk-core/frysk/proc/Proc.java
@@ -167,8 +167,11 @@ public abstract class Proc implements Comparable {
fine.log(this, "new - create attached running proc");
}
- /** XXX: Should not be public. */
- public abstract void sendRefresh();
+ /** XXX: Should not be public; should be frysk.proc.live
+ * private. */
+ public void sendRefresh() {
+ fine.log(this, "sendRefresh");
+ }
/**
* Return the current state as a string.
@@ -211,12 +214,6 @@ public abstract class Proc implements Comparable {
});
}
- /**
- * Request that the Proc's task list be refreshed using system
- * tables.
- */
- public abstract void requestRefresh();
-
protected abstract void performDetach();
/**
diff --git a/frysk-core/frysk/proc/dead/ChangeLog b/frysk-core/frysk/proc/dead/ChangeLog
index 2cf9a3b..8a6170a 100644
--- a/frysk-core/frysk/proc/dead/ChangeLog
+++ b/frysk-core/frysk/proc/dead/ChangeLog
@@ -1,5 +1,8 @@
2008-03-17 Andrew Cagney <cagney@redhat.com>
+ * DeadProc.java (requestRefresh()): Delete.
+ (sendRefresh()): Delete.
+
* TestLinuxCore.java: Use ProcBlockAction.
* TestLinuxCore.java (actionCoreProc()): New; replace
diff --git a/frysk-core/frysk/proc/dead/DeadProc.java b/frysk-core/frysk/proc/dead/DeadProc.java
index 727cd15..a96c5fc 100644
--- a/frysk-core/frysk/proc/dead/DeadProc.java
+++ b/frysk-core/frysk/proc/dead/DeadProc.java
@@ -63,17 +63,6 @@ public abstract class DeadProc extends Proc {
return "dead";
}
- /**
- * Request that the Proc's task list be refreshed using system
- * tables.
- */
- public void requestRefresh() {
- fine.log(this, "requestRefresh");
- }
- public void sendRefresh() {
- fine.log(this, "sendRefresh");
- }
-
protected void performDetach() {
fine.log(this, "performDetach");
// XXX: Fake out for now. What kind of observers would you put
diff --git a/frysk-core/frysk/proc/dummy/ChangeLog b/frysk-core/frysk/proc/dummy/ChangeLog
index fe07764..810823f 100644
--- a/frysk-core/frysk/proc/dummy/ChangeLog
+++ b/frysk-core/frysk/proc/dummy/ChangeLog
@@ -1,5 +1,8 @@
2008-03-17 Andrew Cagney <cagney@redhat.com>
+ * DummyProc.java (requestRefresh()): Delete.
+ (sendRefresh()): Delete.
+
* DummyHost.java: Update; using TaskAttachedObserverXXX.
* DummyTask.java: Ditto.
diff --git a/frysk-core/frysk/proc/dummy/DummyProc.java b/frysk-core/frysk/proc/dummy/DummyProc.java
index 2096835..8dae118 100644
--- a/frysk-core/frysk/proc/dummy/DummyProc.java
+++ b/frysk-core/frysk/proc/dummy/DummyProc.java
@@ -71,8 +71,6 @@ public class DummyProc extends Proc {
public String[] getCmdLine() {
return null;
}
- public void sendRefresh() {
- }
public MemoryMap[] getMaps () {
return null;
}
@@ -82,9 +80,6 @@ public class DummyProc extends Proc {
protected String getStateFIXME() {
return "<dummy>";
}
- public void requestRefresh() {
- throw new RuntimeException("oops!");
- }
protected void performDetach() {
throw new RuntimeException("oops!");
}
diff --git a/frysk-core/frysk/proc/live/ChangeLog b/frysk-core/frysk/proc/live/ChangeLog
index 8f4d670..39d79f9 100644
--- a/frysk-core/frysk/proc/live/ChangeLog
+++ b/frysk-core/frysk/proc/live/ChangeLog
@@ -1,5 +1,8 @@
2008-03-17 Andrew Cagney <cagney@redhat.com>
+ * LinuxPtraceProcState.java (handleRefresh(LinuxPtraceProc)): Delete.
+ * LinuxPtraceProc.java (requestRefresh()): Delete.
+
* TestProcStopped.java: Use ProcBlockObserver.
* LinuxPtraceHost.java: Update; using TaskAttachedObserverXXX.
diff --git a/frysk-core/frysk/proc/live/LinuxPtraceProc.java b/frysk-core/frysk/proc/live/LinuxPtraceProc.java
index b76792a..a49b232 100644
--- a/frysk-core/frysk/proc/live/LinuxPtraceProc.java
+++ b/frysk-core/frysk/proc/live/LinuxPtraceProc.java
@@ -339,19 +339,6 @@ public class LinuxPtraceProc extends LiveProc {
}
/**
- * Request that the Proc's task list be refreshed using system
- * tables.
- */
- public void requestRefresh() {
- fine.log(this, "requestRefresh");
- Manager.eventLoop.add(new ProcEvent() {
- public void execute() {
- newState = oldState().handleRefresh(LinuxPtraceProc.this);
- }
- });
- }
-
- /**
* (Internal) Tell the process that is no longer listed in the
* system table remove itself.
*
diff --git a/frysk-core/frysk/proc/live/LinuxPtraceProcState.java b/frysk-core/frysk/proc/live/LinuxPtraceProcState.java
index 59211ad..15bbe02 100644
--- a/frysk-core/frysk/proc/live/LinuxPtraceProcState.java
+++ b/frysk-core/frysk/proc/live/LinuxPtraceProcState.java
@@ -61,9 +61,6 @@ abstract class LinuxPtraceProcState extends State {
LinuxPtraceProcState handleRemoval(LinuxPtraceProc proc) {
throw unhandled(proc, "handleRemoval");
}
- LinuxPtraceProcState handleRefresh(LinuxPtraceProc proc) {
- throw unhandled(proc, "handleRefresh");
- }
LinuxPtraceProcState handleTaskAttachCompleted(LinuxPtraceProc proc, LinuxPtraceTask task) {
throw unhandled(proc, "handleTaskAttachCompleted");
}
@@ -104,11 +101,6 @@ abstract class LinuxPtraceProcState extends State {
*/
private static final LinuxPtraceProcState detached = new LinuxPtraceProcState ("detached")
{
- LinuxPtraceProcState handleRefresh(LinuxPtraceProc proc) {
- fine.log("handleRefresh", proc);
- proc.sendRefresh ();
- return detached;
- }
LinuxPtraceProcState handleRemoval(LinuxPtraceProc proc) {
fine.log("handleRemoval", proc);
// XXX: What about a dieing proc's tasks, have a
hooks/post-receive
--
frysk system monitor/debugger