This is the mail archive of the frysk-cvs@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[SCM] master: Use BigInteger.compareTo for comparisons in logical operations.


The branch, master has been updated
       via  0af7f15678cc58ed51713bb1c76fb384aa58be6c (commit)
      from  a67dec4fdb23794fced6454ca317a4eb109e36a6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email.

- Log -----------------------------------------------------------------
commit 0af7f15678cc58ed51713bb1c76fb384aa58be6c
Author: Teresa Thomas <tthomas@redhat.com>
Date:   Mon Nov 12 13:12:27 2007 -0500

    Use BigInteger.compareTo for comparisons in logical operations.
    
    frysk-core/frysk/value/ChangeLog
    2007-11-12  Teresa Thomas  <tthomas@redhat.com>
    
    	* IntegerUnit.java: Use BigInteger for logical
    	operations.

-----------------------------------------------------------------------

Summary of changes:
 frysk-core/frysk/value/ChangeLog        |    5 ++++-
 frysk-core/frysk/value/IntegerUnit.java |   13 +++++++------
 2 files changed, 11 insertions(+), 7 deletions(-)

First 500 lines of diff:
diff --git a/frysk-core/frysk/value/ChangeLog b/frysk-core/frysk/value/ChangeLog
index 226c16f..39d3690 100644
--- a/frysk-core/frysk/value/ChangeLog
+++ b/frysk-core/frysk/value/ChangeLog
@@ -1,7 +1,10 @@
 2007-11-12  Teresa Thomas  <tthomas@redhat.com>
 
+	* IntegerUnit.java: Use BigInteger for logical
+	operations.
+
 	* IntegerUnit.java: Use asLong() instead of 
-	asBigInteger().longValue().
+	asBigInteger().longValue(). 
 
 2007-11-11  Stan Cox  <scox@redhat.com>
 
diff --git a/frysk-core/frysk/value/IntegerUnit.java b/frysk-core/frysk/value/IntegerUnit.java
index 663f193..3c6d9e4 100644
--- a/frysk-core/frysk/value/IntegerUnit.java
+++ b/frysk-core/frysk/value/IntegerUnit.java
@@ -39,6 +39,7 @@
 
 package frysk.value;
 
+import java.math.BigInteger;
 /**
  * Arithmetic and logical Operation handling 
  * for integers.
@@ -126,19 +127,19 @@ public class IntegerUnit
 
     public Value logicalAnd(Value v1, Value v2) {
 	return retType.createValue
-	               ((v1.asLong() == 0 ? false : true)
-		     && (v2.asLong() == 0 ? false : true) ? 1 : 0);
+	       ((v1.asBigInteger().compareTo(BigInteger.ZERO) == 0 ? false : true)
+             && (v2.asBigInteger().compareTo(BigInteger.ZERO) == 0 ? false : true) ? 1 : 0);
     }    
     public Value logicalOr(Value v1, Value v2) {
 	return retType.createValue
-	               ((v1.asLong() == 0 ? false : true)
-		     || (v2.asLong() == 0 ? false : true) ? 1 : 0);
+	       ((v1.asBigInteger().compareTo(BigInteger.ZERO) == 0 ? false : true)
+	     || (v1.asBigInteger().compareTo(BigInteger.ZERO) == 0 ? false : true) ? 1 : 0);
     }  
     public Value logicalNegation(Value v1) {
 	return retType.createValue
-                       (v1.asLong() == 0 ? 1 : 0);
+               (v1.asBigInteger().compareTo(BigInteger.ZERO) == 0 ? 1 : 0);
     }    
     public boolean getLogicalValue (Value v1) {
-	return ((v1.asLong() == 0) ? false : true);
+	return ((v1.asBigInteger().compareTo(BigInteger.ZERO) == 0) ? false : true);
     }    
 }
\ No newline at end of file


hooks/post-receive
--
frysk system monitor/debugger


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]