This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH v2] libelf: Use int64_t for offsets in libelf.h
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 13 Oct 2015 13:41:24 +0200
- Subject: Re: [PATCH v2] libelf: Use int64_t for offsets in libelf.h
On Mon, 2015-10-12 at 10:44 -0700, Roland McGrath wrote:
> > I note that this is a deliberate difference between the elfutils libelf
> > interface and other libelf implementations, which use off_t in the
> > public interface and don't have LFS support on 32bit systems. We were
> > lucky enough to use off64_t, then loff_t, from the start, so we always
> > support LFS as far as possible.
>
> Actually for early releases we used off_t in the public header but compiled
> the library with _FILE_OFFSET_BITS=64, so the ABI was broken for vanilla
> 32-bit clients of the library.
You are right. I didn't look back far enough. elfutils 0.129 and earlier
did indeed use off_t in the public headers. So not always, but only for
the last 8 years. Still a respectable time. At least a couple of years
longer than I have been involved with the project.