This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: New testfile: dwarf-getstring
- From: Roland McGrath <roland at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 02 Mar 2011 12:33:16 -0800
- Subject: Re: New testfile: dwarf-getstring
The normal way to send code is as a single patch, except for the ChangeLog
entries (which should be prepended just like you did it). The new files
should be part of the patch, and it should be done so that "patch -p1" or
"patch -p0" applies it correctly (or ideally, "git apply --index"). The
easiest thing to do is to do your work on a local git branch and then use
"git diff" or "git format-patch" to make the patch.
Really the best thing to do is to join the "gitelfutils" group via
the https://admin.fedoraproject.org/accounts system. Once you're
approved there, you can push to git directly. The convention is
that you are free to push any branches you like that are called
<username>/* where <username> is your fedoraproject.org user name
(and * is anything, of course). If you push a branch like that with
a new change, then it is very easy for us to merge it in.
The dwarf_getstring function is not one that really ever gets used, so
there isn't a lot of need for this. But anything improving the test
coverage is a good thing, and that test is just fine as it's written.
It's a fine place to start for a first contribution.
Thanks,
Roland