This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: sizeof - kernel modules
- From: Josh Stone <jistone at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 16 Jun 2015 14:36:52 -0700
- Subject: Re: sizeof - kernel modules
On 06/16/2015 02:31 PM, Peter Robinson wrote:
> On Tue, Jun 16, 2015 at 10:26 PM, Dennis Gilmore <dennis@ausil.us> wrote:
>> On Tuesday, June 16, 2015 02:17:10 PM Mark Wielaard wrote:
>>> On Tue, 2015-06-16 at 00:20 +0200, Mark Wielaard wrote:
>>>> Simplest probably is to just revert this one patch and do a elfutils
>>>> 0.163 release with just that (and the translation updates). The issue
>>>> that this was preventing (disk full with ELF_C_RDWR_MMAP, ftruncate
>>>> appear to succeed, write in memory map causes SIGBUS) is probably less
>>>> likely to trigger than this regression.
>>>
>>> Even simpler is to always just (also) call ftruncate to set the right
>>> file size. Which is what the attached patch does. It also includes some
>>> test cases to check in-place-eu-strip actually reduces the file size.
>>>
>>> I'll update the elfutils fedora package so there is a fix right now. But
>>> unless people complain I would like to just make a 0.163 release end of
>>> the week with this fix and any other urgent fixes because I think this
>>> is a somewhat bad regression and we should urge people to not just
>>> patch, but to upgrade to a known good version.
>>
>> We need this fixed for the mass rebuild that is due to start right now. so
>> please apply the patch ASAP and let me know so I can start the rebuild
>
> It's already applied in NVR elfutils-0.162-2.fc23
>
> http://koji.fedoraproject.org/koji/buildinfo?buildID=646258
Yes. It doesn't appear to have landed on mirrors yet, but it is in
f23-build. I just confirmed that it's reducing files properly now.