This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH v3 1/6] dwarf_elf_begin: Add .gnu_debugaltlink to the sectiondata array
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 18 Apr 2014 11:28:29 +0200
- Subject: Re: [PATCH v3 1/6] dwarf_elf_begin: Add .gnu_debugaltlink to the sectiondata array
On Tue, 2014-04-15 at 14:04 +0200, Florian Weimer wrote:
> And use it if DWZ mode is enabled.
>
> +2014-04-15 Florian Weimer <fweimer@redhat.com>
> +
> + * libdwP.h (enum IDX_gnu_debugaltlink): New.
> + * dwarf_begin_elf.c (dwarf_scnnames): Increase string size and add
> + .gnu_debugaltlink.
> + (check_section): Obtain .gnu_debugaltlink section from the
> + setiondata array.
Looks good. No comments except that in theory we could hide more behind
#ifdef ENABLE_DWZ. But given that I hope to remove that and just enable
dwz support by default for 0.159 I think it doesn't matter.
I'll integrate it into the mjw/dwelf branch (because it will be used
there and it should go to master when the rest of dwelf is merge IMHO).
Thanks,
Mark