This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: Various SIGFPEs on sh_entsize == 0
- From: Petr Machata <pmachata at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 23 Mar 2011 15:42:51 +0100
- Subject: Re: Various SIGFPEs on sh_entsize == 0
Mark Wielaard <mjw@redhat.com> writes:
> On Tue, 2011-03-22 at 06:21 -0700, Roland McGrath wrote:
>> Have you checked the robustify branch?
>
> I assume the usage of the result of gelf_fsize for sh_entsize instead of
> shdr->sh_entsize directly helps guard against some of the same issues.
> But it doesn't seem to be used consistently on the branch, so Petr's
> patch still makes sense to me. Maybe combined with the robustify
> branch
I reworked the patch on top of the robustify branch, which already had
the elflint fixes that I posted. This time around, I was more thorough
in picking up various places in readelf.c where sh_entsize use might
lead to SIGFPE. It should all use gelf_fsize now. The branch
pmachata/sh_entsize was force-updated and has now the new content.
> approach. There were a couple more interesting fixes on that branch.
> What is preventing them to be merged with master? Need a more close
> review? Are these used by default on fedora?
I'm wondering about this, too.
PM