This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] elflint: Only check the PT_TLS phdr if it actually exists.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 19 Jun 2015 13:05:45 +0200
- Subject: Re: [PATCH] elflint: Only check the PT_TLS phdr if it actually exists.
On Thu, 2015-06-18 at 11:28 -0700, Roland McGrath wrote:
> It should complain separately for that case, not just be silent.
You are right. I made it into its own case and complain.
> Arguably, it should just barf if any gelf_getphdr call fails, because
> that can only be due to a deep bogon.
Yeah, maybe elflint should really just wrap gelf_getphdr and
gelf_getshdr and complain and quit when they return NULL instead of
trying to continue. The ELF file is probably completely bogus anyway in
those cases.
Thanks,
Mark