This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Use -Wformat=2 by default for all files.
- From: Petr Machata <pmachata at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 30 Jan 2014 16:25:47 +0100
- Subject: Re: [PATCH] Use -Wformat=2 by default for all files.
Mark Wielaard <mjw@redhat.com> writes:
> diff --git a/backends/aarch64_regs.c b/backends/aarch64_regs.c
> index aec201f..bd10c46 100644
> --- a/backends/aarch64_regs.c
> +++ b/backends/aarch64_regs.c
> @@ -47,32 +47,48 @@ aarch64_register_info (Ebl *ebl __attribute__ ((unused)),
> return 128;
>
> ssize_t
> - regtype (const char *setname, int type, const char *fmt, int arg)
> + regtype (const char *setname, int type, const char *rname, bool nr, int arg)
Regarding this chunk, actually this can be made simpler by using
__attribute__ ((format)). I had thought that would be too involved, but
it's actually pretty clean IMO. What say you?