This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] For clang use Blocks instead of nested functions.


Okay, it is easy for me to resend the patch through git send-email.

For the moved code, it would be difficult to review without some smart diff
tool. For in-place replacement of nested functions to macros, the diff is
actually easier to verify.

If the original intention is to inline those nested functions,
I think macros should be fine. I don't mind moving them to
file scope static functions either, if the performance difference of
not-inlining and passing extra arguments is not important.


On Fri, Sep 11, 2015 at 3:41 PM, Roland McGrath <roland@hack.frob.com>
wrote:

> Macros are the last resort.  When they can be file-scope static functions
> without a huge pain in the ass, always do that instead.  I think we need to
> take these case by case, rather than trying to review one giant patch.
> Also, attachments suck and you'll get far quicker review if you avoid them.
>
Okay, it is easy for me to resend the patch through git send-email.

For the moved code, it would be difficult to review without some smart diff tool. For in-place replacement of nested functions to macros, the diff is actually easier to verify.

If the original intention is to inline those nested functions,
I think macros should be fine. I don't mind moving them to
file scope static functions either, if the performance difference of not-inlining and passing extra arguments is not important.


On Fri, Sep 11, 2015 at 3:41 PM, Roland McGrath <roland@hack.frob.com> wrote:
Macros are the last resort.  When they can be file-scope static functions
without a huge pain in the ass, always do that instead.  I think we need to
take these case by case, rather than trying to review one giant patch.
Also, attachments suck and you'll get far quicker review if you avoid them.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]