This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Move nested functions in gzip.c to file scope.
- From: Chih-Hung Hsieh <chh at google dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 13 Nov 2015 11:14:10 -0800
- Subject: Re: [PATCH] Move nested functions in gzip.c to file scope.
I saw that pread_retry used fd and start_offset with or without USE_INFLATE.
Is there a way to change that part or should we just leave fd and
start_offset in the unzip_state?
On Fri, Nov 13, 2015 at 8:26 AM, Mark Wielaard <mjw@redhat.com> wrote:
> On Tue, 2015-11-03 at 12:04 -0800, Chih-hung Hsieh wrote:
> > Sorry about that.
> > Could you take a look of the new attached 0002*gzip.c*patch?
>
> Yes, this works. But I think the state is a bit too big. Like zf, both
> fd and start_offset are really only used by open_stream when gzip is
> used. So both can be guarded by #if !USE_INFLATE as the diff attached
> does. Does that make sense?
>
> Thanks,
>
> Mark
>
I saw that pread_retry used fd and start_offset with or without USE_INFLATE.
Is there a way to change that part or should we just leave fd and start_offset in the unzip_state?
On Fri, Nov 13, 2015 at 8:26 AM, Mark Wielaard
<mjw@redhat.com> wrote:
On Tue, 2015-11-03 at 12:04 -0800, Chih-hung Hsieh wrote:
> Sorry about that.
> Could you take a look of the new attached 0002*gzip.c*patch?
Yes, this works. But I think the state is a bit too big. Like zf, both
fd and start_offset are really only used by open_stream when gzip is
used. So both can be guarded by #if !USE_INFLATE as the diff attached
does. Does that make sense?
Thanks,
Mark