Re: [PATCH] Do without union of variable length arrays.

[Chih-Hung Hsieh <chh at google dot com>]

Thanks. I updated ChangLog files in the new attached 0005*patch file.

I think we mean the new assert(count<128) statement in readelf.c.
It is now explained in ChangeLog that assert was added because alloca was
used for the new dynamic allocation. For other malloc and xmalloc, overflow
tests were added.




On Thu, Oct 1, 2015 at 10:22 AM, Roland McGrath <roland@hack.frob.com>
wrote:

> In ChangeLog entries, "Likewise" should be followed by a period.
>
> You have some readelf changes that are not directly part of avoiding
> unions.  They are also not described in the src/ChangeLog entry.
> Please post those separately and describe their justifications.
>
>
> Thanks,
> Roland
>

Thanks. I updated ChangLog files in the new attached 0005*patch file.

I think we mean the new assert(count<128) statement in readelf.c.

It is now explained in ChangeLog that assert was added because alloca was used for the new dynamic allocation. For other malloc and xmalloc, overflow tests were added.

On Thu, Oct 1, 2015 at 10:22 AM, Roland McGrath <roland@hack.frob.com> wrote:

In ChangeLog entries, "Likewise" should be followed by a period.

You have some readelf changes that are not directly part of avoiding
unions.  They are also not described in the src/ChangeLog entry.
Please post those separately and describe their justifications.


Thanks,
Roland

Attachment: 0005-Do-without-union-of-variable-length-arrays.patch
Description: Binary data