This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [patch 2/2] Implement reglocs for s390/s390x
- From: Roland McGrath <roland at hack dot frob dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 29 Jan 2013 14:48:48 -0800
- Subject: Re: [patch 2/2] Implement reglocs for s390/s390x
> --- a/backends/arm_corenote.c
> +++ b/backends/arm_corenote.c
> @@ -84,7 +84,7 @@ static const Ebl_Core_Item vfp_items[] =
> {
> .name = "fpscr", .group = "register",
> .offset = 0,
> - .count = 0, .type = ELF_T_WORD, .format = 'x',
> + .type = ELF_T_WORD, .format = 'x',
> },
> };
>
Drop this unrelated change. It's fine to do it as a separate commit with a
proper ChangeLog entry for it.
> - FIELD (ULONG, pr_reg[PRSTATUS_REGS_SIZE / sizeof (ULONG)]);
> + union
> + {
> + FIELD (ULONG, pr_reg[PRSTATUS_REGS_SIZE / sizeof (ULONG)]);
> + }
> +#ifdef ALIGN_PR_REG
> + __attribute__ ((aligned (ALIGN_PR_REG)))
> +#endif
> + ;
It seems odd to use union rather than struct for this.
> +/* S390 specific core note handling.
"S390-specific".
This seems fine with those nits fixed.
Thanks,
Roland