This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 2/2] Support AArch64 architecture
- From: Petr Machata <pmachata at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 14 Nov 2013 12:24:03 +0100
- Subject: Re: [PATCH 2/2] Support AArch64 architecture
Petr Machata <pmachata@redhat.com> writes:
> + if ((i = member_is_fp (ftypedie, sizep, countp)) == 0)
> + {
> + *countp = tot_size / *sizep;
> + return 0;
> + }
> +
> + return 1;
This should be return i;
> + }
> +
> + /* Find first DW_TAG_member and determine its type. */
> + Dwarf_Die member;
> + if ((i = dwarf_child (ftypedie, &member) != 0))
> + return i;
> +
> + if ((i = skip_until (&member, DW_TAG_member)) != 0)
> + return i;
> +
> + *countp = 0;
> + if ((i = member_is_fp (&member, sizep, countp)) != 0)
> + return i;
> +
> + while ((i = dwarf_siblingof (&member, &member)) == 0
> + && (i = skip_until (&member, DW_TAG_member)) == 0)
> + {
> + Dwarf_Word size, count;
> + if ((i = member_is_fp (&member, &size, &count)) != 0)
> + return i;
> +
> + if (*sizep != size)
> + return 1;
> +
> + *countp += count;
> + }
> +
This should probably have a comment.
/* At this point we already have one FP member, which means FTYPEDIE is
an HFA. So either return 0, or propagate error. */
> + return i < 0 ? i : 0;
> +}
I'll wait for other people's comments before the next submission.
Thanks,
PM