Re: pmachata/reader_hooks review

[Petr Machata <pmachata at redhat dot com>]

Roland McGrath wrote:
>> Roland McGrath wrote:
>>> * dwarf_formudata needs special treatment.
>> This is now on the branch.  The new function is called 
>> __libdw_read_udata_address.  
> 
> "address" does not make sense here--it's an offset that's being relocated.
> It should use the read_offset hook internally.  I would call it something
> like __libdw_formptr, since it's the attribute decoder for "*ptr" classes.

Aha, I believe I misunderstood what you said earlier.  I _moved_ address 
relocation semantics into formptr, instead of leaving them in formudata 
and introducing offset semantics in formptr.  Fixed now.

The rest is in, too.

Thanks,
PM

Attachment: signature.asc
Description: PGP signature